linux-kernel - Re: [patch 00/53] x86/topology: The final installment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28ea3d469ba8e017e60908ec26624c80cbf8a3ce.camel@intel.com>
Date:   Thu, 10 Aug 2023 03:28:03 +0000
From:   "Zhang, Rui" <rui.zhang@...el.com>
To:     "tglx@...utronix.de" <tglx@...utronix.de>,
        "Mehta, Sohil" <sohil.mehta@...el.com>,
        "peterz@...radead.org" <peterz@...radead.org>
CC:     "Gross, Jurgen" <jgross@...e.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "arjan@...ux.intel.com" <arjan@...ux.intel.com>,
        "kprateek.nayak@....com" <kprateek.nayak@....com>,
        "mikelley@...rosoft.com" <mikelley@...rosoft.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "ray.huang@....com" <ray.huang@....com>,
        "andrew.cooper3@...rix.com" <andrew.cooper3@...rix.com>,
        "Sivanich, Dimitri" <dimitri.sivanich@....com>,
        "paulmck@...nel.org" <paulmck@...nel.org>,
        "kan.liang@...ux.intel.com" <kan.liang@...ux.intel.com>,
        "andy@...radead.org" <andy@...radead.org>,
        "Tang, Feng" <feng.tang@...el.com>
Subject: Re: [patch 00/53] x86/topology: The final installment

Hi, Thomas,

> > CPU topo: Max. logical packages:   2
> > CPU topo: Max. logical dies:       2
> > CPU topo: Max. dies per package:   1
> > CPU topo: Max. threads per core:   2
> > CPU topo: Num. cores per package:    10
> > CPU topo: Num. threads per package:  20
> > CPU topo: Allowing 40 present CPUs plus 0 hotplug CPUs
> > CPU topo: Thread    :    40
> > CPU topo: Core      :    20
> > CPU topo: Module    :     2
> > CPU topo: Tile      :     2
> > CPU topo: Die       :     2
> > CPU topo: Package   :     2
> > 
> > domain: Thread     shift: 1 dom_size:     2 max_threads:     2
> > domain: Core       shift: 5 dom_size:    16 max_threads:    32
> > domain: Module     shift: 5 dom_size:     1 max_threads:    32
> > domain: Tile       shift: 5 dom_size:     1 max_threads:    32
> > domain: Die        shift: 5 dom_size:     1 max_threads:    32
> > domain: Package    shift: 5 dom_size:     1 max_threads:    32
> > 
> > /sys/kernel/debug/x86/topo/cpus/39
> > online:              1
> > initial_apicid:      39
> > apicid:              39
> > pkg_id:              1
> > die_id:              1
> > cu_id:               255
> > core_id:             12
> > logical_pkg_id:      1
> > logical_die_id:      1
> > llc_id:              32
> > l2c_id:              56
> > amd_node_id:         0
> > amd_nodes_per_pkg:   0
> > num_threads:         20
> > num_cores:           10
> > max_dies_per_pkg:    1
> > max_threads_per_core:2
> 
> That makes much more sense now.
> 
> Zhang, can you please follow up on:
> 
>  
> https://lore.kernel.org/all/613df280116378115585d0c483f7e186cffaeb58.camel@intel.com/
> 
> or otherwise I just polish up PeterZ's variant of it tomorrow.
> 
Sorry for the late response. I was in the reviewing of the previous
patch series and missed this one.

IMO, PeterZ' patch already follows the suggestion at
https://lore.kernel.org/all/87pm4bp54z.ffs@tglx/
And https://lore.kernel.org/all/87jzukqjvf.ffs@tglx/ is not needed
because there are no duplicate APIC IDs from LAPIC and x2APIC anymore
with the above patch.

So I think we can go with PeterZ' patch.

thanks,
rui