linux-kernel - Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CUOYMVSMYYY0.2862H5KZKTIXG@wks-101042-mac.ad.tuni.fi>
Date:   Thu, 10 Aug 2023 18:12:29 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        <peterhuewe@....de>
Cc:     <jgg@...pe.ca>, <linux-integrity@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <l.sanfilippo@...bus.com>,
        <jsnitsel@...hat.com>, <pmenzel@...gen.mpg.de>
Subject: Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_PRODUCT_VERSION string

On Tue Aug 8, 2023 at 12:37 PM EEST, Péter Ujfalusi wrote:
>
>
> On 08/08/2023 09:18, Peter Ujfalusi wrote:
> > The patch which made it to the kernel somehow lost the "01" from the
> > string, making the match to not work anymore.
> > 
> > Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
> > Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
> > ---
> > Hi Jarkko,
> > 
> > Can you send this patch for the 6.5 cycle?
> > edb13d7bb034 was applied in 6.5-rc3 and I just updated my work tree to notice
> > the regression.
> > 
> > Thank you,
> > Peter
> > 
> >  drivers/char/tpm/tpm_tis.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > index ac4daaf294a3..2bb9901a329a 100644
> > --- a/drivers/char/tpm/tpm_tis.c
> > +++ b/drivers/char/tpm/tpm_tis.c
> > @@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
> >  		.ident = "UPX-TGL",
> >  		.matches = {
> >  			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> > -			DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
> > +			DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL01"),
>
> The DMI property also got changed in the applied patch, it should have
> been DMI_PRODUCT_NAME, I will send v2 shortly, please ignore this version

sure

BR, Jarkko