linux-kernel - Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CUOYNABJ9NIW.6PF43I2S20K3@wks-101042-mac.ad.tuni.fi>
Date:   Thu, 10 Aug 2023 18:13:00 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Peter Ujfalusi" <peter.ujfalusi@...ux.intel.com>,
        <peterhuewe@....de>
Cc:     <jgg@...pe.ca>, <linux-integrity@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <l.sanfilippo@...bus.com>,
        <jsnitsel@...hat.com>, <pmenzel@...gen.mpg.de>
Subject: Re: [PATCH] tpm: tpm_tis: Fix UPX-i11 DMI_MATCH condition

On Tue Aug 8, 2023 at 12:48 PM EEST, Peter Ujfalusi wrote:
> The patch which made it to the kernel somehow changed the
> match condition from
> DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01")
> to
> DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL")
>
> Revert back to the correct match condition to disable the
> interrupt mode on the board.
>
> Link: https://lore.kernel.org/lkml/20230524085844.11580-1-peter.ujfalusi@linux.intel.com/
> Fixes: edb13d7bb034 ("tpm: tpm_tis: Disable interrupts *only* for AEON UPX-i11")
> ---
>  drivers/char/tpm/tpm_tis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> index ac4daaf294a3..3c0f68b9e44f 100644
> --- a/drivers/char/tpm/tpm_tis.c
> +++ b/drivers/char/tpm/tpm_tis.c
> @@ -183,7 +183,7 @@ static const struct dmi_system_id tpm_tis_dmi_table[] = {
>  		.ident = "UPX-TGL",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "AAEON"),
> -			DMI_MATCH(DMI_PRODUCT_VERSION, "UPX-TGL"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "UPX-TGL01"),
>  		},
>  	},
>  	{}

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko