linux-kernel - Re: [PATCH] gpiolib: fix reference leaks when removing GPIO chips still in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2023 18:19:17 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Kent Gibson <warthog618@...il.com>, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpiolib: fix reference leaks when removing GPIO chips
 still in use

On Thu, Aug 10, 2023 at 06:17:26PM +0300, Andy Shevchenko wrote:
> On Thu, Aug 10, 2023 at 12:03:34PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

...

> >  void gpiod_free(struct gpio_desc *desc)
> >  {
> > -	if (desc && desc->gdev && gpiod_free_commit(desc)) {
> > -		module_put(desc->gdev->owner);
> > -		gpio_device_put(desc->gdev);
> > -	} else {
> > +	if (!desc)
> > +		return;

> 	VALIDATE_DESC_VOID() ?

If it is not possible to use, the comment should be added, like we have in
gpiod_to_irq().

> > +	if (!gpiod_free_commit(desc))
> >  		WARN_ON(extra_checks);
> > -	}
> > +
> > +	gpio_device_put(desc->gdev);
> > +	module_put(desc->gdev->owner);
> >  }

-- 
With Best Regards,
Andy Shevchenko