[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230810-opossum-constable-719273142ce3@spud>
Date: Thu, 10 Aug 2023 17:15:26 +0100
From: Conor Dooley <conor@...nel.org>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: "David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v2 09/10] dt-bindings: net: snps,dwmac: add per
channel irq support
On Thu, Aug 10, 2023 at 11:59:06PM +0800, Jisheng Zhang wrote:
> On Tue, Aug 08, 2023 at 08:39:58AM +0100, Conor Dooley wrote:
> > On Tue, Aug 08, 2023 at 12:41:50AM +0800, Jisheng Zhang wrote:
> > > The IP supports per channel interrupt, add support for this usage case.
> > >
> > > Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> > > ---
> > > .../devicetree/bindings/net/snps,dwmac.yaml | 33 +++++++++++++++++++
> > > 1 file changed, 33 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > index 5d81042f5634..5a63302ad200 100644
> > > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > > @@ -109,6 +109,7 @@ properties:
> > > - description: The interrupt that occurs when Rx exits the LPI state
> > > - description: The interrupt that occurs when Safety Feature Correctible Errors happen
> > > - description: The interrupt that occurs when Safety Feature Uncorrectible Errors happen
> > > + - description: All of the rx/tx per-channel interrupts
> > >
> > > interrupt-names:
> > > minItems: 1
> > > @@ -118,6 +119,38 @@ properties:
> > > - const: eth_lpi
> > > - const: sfty_ce
> > > - const: sfty_ue
> > > + - const: rx0
> > > + - const: rx1
> > > + - const: rx2
> > > + - const: rx3
> > > + - const: rx4
> > > + - const: rx5
> > > + - const: rx6
> > > + - const: rx7
> > > + - const: rx8
> > > + - const: rx9
> > > + - const: rx10
> > > + - const: rx11
> > > + - const: rx12
> > > + - const: rx13
> > > + - const: rx14
> > > + - const: rx15
> > > + - const: tx0
> > > + - const: tx1
> > > + - const: tx2
> > > + - const: tx3
> > > + - const: tx4
> > > + - const: tx5
> > > + - const: tx6
> > > + - const: tx7
> > > + - const: tx8
> > > + - const: tx9
> > > + - const: tx10
> > > + - const: tx11
> > > + - const: tx12
> > > + - const: tx13
> > > + - const: tx14
> > > + - const: tx15
> >
> > I don't think Rob's comment about having added 2 interrupts but 32
> > interrupt names has been resolved.
>
> I misunderstood Rob's comment. Now I'm not sure whether dt-binding
> can support regex or something or not, or let ask for advice in the
> following way: how could I write the dt-binding in this case? I didn't
> find similar examples so far. I'm not sure listing possible
> description and const properties for all channel interrupts is suitable.
I'm not sure that there is a better way. Rob maybe has a suggestion.
> > Did you actually test putting this many interrupts into a node?
> > AFAICT, any more than 6 will cause complaints.
>
> I tried 12rx and 12tx interrupts in a node, didn't see dtc warning.
> so I guess the complaints are from dtb check? I will try to reproduce
> them.
I triggered some by putting more entries into the example in this
binding & doing dt binding check.
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists