[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <169168449014.480213.11243622755862466051.robh@kernel.org>
Date: Thu, 10 Aug 2023 10:21:30 -0600
From: Rob Herring <robh@...nel.org>
To: Aleksandr Shubin <privatesub2@...il.com>
Cc: Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Heiko Stuebner <heiko.stuebner@...ll.eu>,
Palmer Dabbelt <palmer@...belt.com>,
Conor Dooley <conor+dt@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
linux-riscv@...ts.infradead.org,
Thierry Reding <thierry.reding@...il.com>,
linux-pwm@...r.kernel.org, Chen-Yu Tsai <wens@...e.org>,
devicetree@...r.kernel.org,
Paul Walmsley <paul.walmsley@...ive.com>,
linux-arm-kernel@...ts.infradead.org,
Albert Ou <aou@...s.berkeley.edu>, linux-sunxi@...ts.linux.dev,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Cristian Ciocaltea <cristian.ciocaltea@...labora.com>,
linux-kernel@...r.kernel.org,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH v4 1/3] dt-bindings: pwm: Add binding for Allwinner
D1/T113-S3/R329 PWM controller
On Thu, 10 Aug 2023 17:54:26 +0300, Aleksandr Shubin wrote:
> Allwinner's D1, T113-S3 and R329 SoCs have a new pwm
> controller witch is different from the previous pwm-sun4i.
>
> The D1 and T113 are identical in terms of peripherals,
> they differ only in the architecture of the CPU core, and
> even share the majority of their DT. Because of that,
> using the same compatible makes sense.
> The R329 is a different SoC though, and should have
> a different compatible string added, especially as there
> is a difference in the number of channels.
>
> D1 and T113s SoCs have one PWM controller with 8 channels.
> R329 SoC has two PWM controllers in both power domains, one of
> them has 9 channels (CPUX one) and the other has 6 (CPUS one).
>
> Add a device tree binding for them.
>
> Signed-off-by: Aleksandr Shubin <privatesub2@...il.com>
> ---
> .../bindings/pwm/allwinner,sun20i-pwm.yaml | 86 +++++++++++++++++++
> 1 file changed, 86 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pwm/allwinner,sun20i-pwm.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230810145443.1053387-2-privatesub2@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Powered by blists - more mailing lists