[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9a8de176-2786-99e4-5f84-3be541612283@csgroup.eu>
Date: Thu, 10 Aug 2023 17:21:11 +0000
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Arnd Bergmann <arnd@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 06/17] macintosh/ams: mark ams_init() static
Le 10/08/2023 à 16:19, Arnd Bergmann a écrit :
> From: Arnd Bergmann <arnd@...db.de>
>
> This is the module init function, which by definition is used only
> locally, so mark it static to avoid a warning:
>
> drivers/macintosh/ams/ams-core.c:179:12: error: no previous prototype for 'ams_init' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>
> ---
> drivers/macintosh/ams/ams-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/macintosh/ams/ams-core.c b/drivers/macintosh/ams/ams-core.c
> index 877e8cb231283..c978b4272daa5 100644
> --- a/drivers/macintosh/ams/ams-core.c
> +++ b/drivers/macintosh/ams/ams-core.c
> @@ -176,7 +176,7 @@ int ams_sensor_attach(void)
> return result;
> }
>
> -int __init ams_init(void)
> +static int __init ams_init(void)
> {
> struct device_node *np;
>
Powered by blists - more mailing lists