[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9646c74c-1402-05fb-4e7f-60d2e7818831@redhat.com>
Date: Thu, 10 Aug 2023 13:05:33 -0500
From: Frank Sorenson <frank@...rocks.com>
To: Jeff Layton <jlayton@...nel.org>,
Christian Brauner <brauner@...nel.org>,
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
Jan Kara <jack@...e.com>
Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 2/2] fat: make fat_update_time get its own timestamp
On 8/10/23 08:12, Jeff Layton wrote:
> In later patches, we're going to drop the "now" parameter from the
> update_time operation. Fix fat_update_time to fetch its own timestamp.
> It turns out that this is easily done by just passing a NULL timestamp
> pointer to fat_truncate_time.
>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
Reviewed-by: Frank Sorenson <sorenson@...hat.com>
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fat/misc.c b/fs/fat/misc.c
> index 37f4afb346af..f2304a1054aa 100644
> --- a/fs/fat/misc.c
> +++ b/fs/fat/misc.c
> @@ -347,7 +347,7 @@ int fat_update_time(struct inode *inode, int flags)
> return 0;
>
> if (flags & (S_ATIME | S_CTIME | S_MTIME)) {
> - fat_truncate_time(inode, now, flags);
> + fat_truncate_time(inode, NULL, flags);
> if (inode->i_sb->s_flags & SB_LAZYTIME)
> dirty_flags |= I_DIRTY_TIME;
> else
>
Powered by blists - more mailing lists