[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4f4d0cc0-6e56-4608-bed0-4bad3adc3c7b@arm.com>
Date: Thu, 10 Aug 2023 19:54:16 +0100
From: Ryan Roberts <ryan.roberts@....com>
To: Linus Torvalds <torvalds@...ux-foundation.org>,
Yu Zhao <yuzhao@...gle.com>
Cc: Hugh Dickins <hughd@...gle.com>,
Johannes Weiner <hannes@...xchg.org>,
Will Deacon <will@...nel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Nick Piggin <npiggin@...il.com>,
Peter Zijlstra <peterz@...radead.org>,
Christian Borntraeger <borntraeger@...ux.ibm.com>,
Sven Schnelle <svens@...ux.ibm.com>,
Arnd Bergmann <arnd@...db.de>,
"Matthew Wilcox (Oracle)" <willy@...radead.org>,
David Hildenbrand <david@...hat.com>,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
Yin Fengwei <fengwei.yin@...el.com>,
Yang Shi <shy828301@...il.com>,
"Huang, Ying" <ying.huang@...el.com>, Zi Yan <ziy@...dia.com>,
linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/4] mm/mmu_gather: Remove encoded_page infrastructure
On 10/08/2023 19:31, Linus Torvalds wrote:
> On Thu, 10 Aug 2023 at 10:35, Yu Zhao <yuzhao@...gle.com> wrote:
>>
>> Adding the original author and reviewers... They might want (need) to
>> take a look at this series.
>
> It looks fine to me. The important part is that the rmap removal has
> to be done after the TLB flush, but before the page table lock is
> released.
Yes, we still abide by this rule for the !PageAnon(page) pages.
>
> That used to be a special thing for anonymous pages and thus needed
> that special flag. But if it's done for *all* pages the need to flag
> pages goes away.
I think you misstyped - assuming you meant pagecache pages rather than anonymous
pages?
>
> I see no issues with this, although obviously I might have missed something.
Thanks for looking so quickly - really appreciate it. And sorry not to have
included you initially.
Thanks,
Ryan
>
> Linus
Powered by blists - more mailing lists