[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJZ5v0gK2dGPYEMKaKayUGuXpGns-w3V7RBpJwYc3=h-JLDdNg@mail.gmail.com>
Date: Thu, 10 Aug 2023 21:22:30 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Mihai Carabas <mihai.carabas@...cle.com>
Cc: Joao Martins <joao.m.martins@...cle.com>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
"H. Peter Anvin" <hpa@...or.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Wanpeng Li <wanpengli@...cent.com>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Kees Cook <keescook@...omium.org>,
Peter Zijlstra <peterz@...radead.org>,
Petr Mladek <pmladek@...e.com>,
Ard Biesheuvel <ardb@...nel.org>,
Sami Tolvanen <samitolvanen@...gle.com>,
Nicholas Piggin <npiggin@...il.com>,
Juerg Haefliger <juerg.haefliger@...onical.com>,
Mickaël Salaün <mic@...ikod.net>,
Arnd Bergmann <arnd@...db.de>,
Ankur Arora <ankur.a.arora@...cle.com>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
kvm@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/7] cpuidle-haltpoll: Make boot_option_idle_override
check X86 specific
On Wed, Aug 9, 2023 at 2:52 PM Mihai Carabas <mihai.carabas@...cle.com> wrote:
>
> From: Joao Martins <joao.m.martins@...cle.com>
>
> In the pursuit of letting it build on ARM let's not include what is x86
> specific.
>
> Signed-off-by: Joao Martins <joao.m.martins@...cle.com>
> Signed-off-by: Mihai Carabas <mihai.carabas@...cle.com>
> ---
> drivers/cpuidle/cpuidle-haltpoll.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpuidle/cpuidle-haltpoll.c b/drivers/cpuidle/cpuidle-haltpoll.c
> index e66df22f9695..0ca3c8422eb6 100644
> --- a/drivers/cpuidle/cpuidle-haltpoll.c
> +++ b/drivers/cpuidle/cpuidle-haltpoll.c
> @@ -104,9 +104,11 @@ static int __init haltpoll_init(void)
> int ret;
> struct cpuidle_driver *drv = &haltpoll_driver;
>
> +#ifdef CONFIG_X86
> /* Do not load haltpoll if idle= is passed */
> if (boot_option_idle_override != IDLE_NO_OVERRIDE)
> return -ENODEV;
> +#endif
I'm sure that adding this #ifdef to the function body is avoidable.
> if (!kvm_para_available() || !haltpoll_want())
> return -ENODEV;
> --
Powered by blists - more mailing lists