linux-kernel - Re: [PATCH v3 6/7] sched: Implement shared runqueue in CFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2023 15:11:06 +0800
From:   kernel test robot <lkp@...el.com>
To:     David Vernet <void@...ifault.com>, linux-kernel@...r.kernel.org
Cc:     oe-kbuild-all@...ts.linux.dev, peterz@...radead.org,
        mingo@...hat.com, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, vschneid@...hat.com, tj@...nel.org,
        roman.gushchin@...ux.dev, gautham.shenoy@....com,
        kprateek.nayak@....com, aaron.lu@...el.com,
        wuyun.abel@...edance.com, kernel-team@...a.com
Subject: Re: [PATCH v3 6/7] sched: Implement shared runqueue in CFS

Hi David,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[cannot apply to linus/master v6.5-rc5 next-20230809]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Vernet/sched-Expose-move_queued_task-from-core-c/20230810-061611
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20230809221218.163894-7-void%40manifault.com
patch subject: [PATCH v3 6/7] sched: Implement shared runqueue in CFS
config: sparc-randconfig-r015-20230809 (https://download.01.org/0day-ci/archive/20230810/202308101517.FuIh97h7-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308101517.FuIh97h7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308101517.FuIh97h7-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> kernel/sched/core.c:9768:6: warning: no previous prototype for 'sched_update_domains' [-Wmissing-prototypes]
    9768 | void sched_update_domains(void)
         |      ^~~~~~~~~~~~~~~~~~~~
--
   In file included from kernel/sched/build_utility.c:89:
   kernel/sched/topology.c: In function 'sched_init_domains':
>> kernel/sched/topology.c:2580:17: error: implicit declaration of function 'sched_update_domains'; did you mean 'sched_update_scaling'? [-Werror=implicit-function-declaration]
    2580 |                 sched_update_domains();
         |                 ^~~~~~~~~~~~~~~~~~~~
         |                 sched_update_scaling
   cc1: some warnings being treated as errors


vim +2580 kernel/sched/topology.c

  2558	
  2559	/*
  2560	 * Set up scheduler domains and groups.  For now this just excludes isolated
  2561	 * CPUs, but could be used to exclude other special cases in the future.
  2562	 */
  2563	int __init sched_init_domains(const struct cpumask *cpu_map)
  2564	{
  2565		int err;
  2566	
  2567		zalloc_cpumask_var(&sched_domains_tmpmask, GFP_KERNEL);
  2568		zalloc_cpumask_var(&sched_domains_tmpmask2, GFP_KERNEL);
  2569		zalloc_cpumask_var(&fallback_doms, GFP_KERNEL);
  2570	
  2571		arch_update_cpu_topology();
  2572		asym_cpu_capacity_scan();
  2573		ndoms_cur = 1;
  2574		doms_cur = alloc_sched_domains(ndoms_cur);
  2575		if (!doms_cur)
  2576			doms_cur = &fallback_doms;
  2577		cpumask_and(doms_cur[0], cpu_map, housekeeping_cpumask(HK_TYPE_DOMAIN));
  2578		err = build_sched_domains(doms_cur[0], NULL);
  2579		if (!err)
> 2580			sched_update_domains();
  2581	
  2582		return err;
  2583	}
  2584	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki