linux-kernel - Re: [PATCH] input: keyboard: Add sprd-keypad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAB9BWhf-VAuutVQ3PtyQDozTfPhLBbNPTPtWYTfa6g_sT4ZgTg@mail.gmail.com>
Date:   Thu, 10 Aug 2023 15:48:46 +0800
From:   wenhua lin <wenhua.lin1994@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Wenhua Lin <Wenhua.Lin@...soc.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Samuel Holland <samuel@...lland.org>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Mattijs Korpershoek <mkorpershoek@...libre.com>,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH] input: keyboard: Add sprd-keypad driver

On Tue, Aug 8, 2023 at 4:02 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Tue, Aug 8, 2023, at 09:25, Wenhua Lin wrote:
> > Add matrix keypad driver, support matrix keypad function.
> >
> > Signed-off-by: Wenhua Lin <Wenhua.Lin@...soc.com>
>
> Looks fine to me, just one minor thing to remember:
>
> > +static int __maybe_unused sprd_keypad_resume(struct device *dev)
> > +{
> > +     struct sprd_keypad_data *data = dev_get_drvdata(dev);
> > +     int ret = 0;
> > +
> > +     if (!device_may_wakeup(dev)) {
> > +             ret = sprd_keypad_enable(data);
> > +             if (ret)
> > +                     return ret;
> > +             ret = sprd_keypad_hw_init(data);
> > +     }
> > +
> > +     return ret;
> > +}
> > +
> > +static SIMPLE_DEV_PM_OPS(sprd_keypad_pm_ops,
> > +                     sprd_keypad_suspend, sprd_keypad_resume);
> > +
>
> SIMPLE_DEV_PM_OPS() is deprecated, please use the new
> DEFINE_SIMPLE_DEV_PM_OPS() for all new drivers, and
> remove the __maybe_unused annotation that is no longer
> needed with that.
>
> With that addressed (for the driver in general, I know nothing
> about the drivers/input specifics)
>
> Acked-by: Arnd Bergmann <arnd@...db.de>
>
>      Arnd

Hi Arnd:
   We will fix the problem of SIMPLE_DEV_PM_OPS in patch v2.

Thanks
Wenhua.Lin