linux-kernel - Re: [PATCH v2] media: vcodec: Fix potential array out-of-bounds in encoder queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5EOwT4ZvTLkvT_26UFk4Eg1Hi0iERp=NpmtQ63g3dZ+qw@mail.gmail.com>
Date:   Thu, 10 Aug 2023 16:32:02 +0800
From:   Chen-Yu Tsai <wenst@...omium.org>
To:     Wei Chen <harperchen1110@...il.com>
Cc:     tiffany.lin@...iatek.com, andrew-ct.chen@...iatek.com,
        yunfei.dong@...iatek.com, mchehab@...nel.org,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] media: vcodec: Fix potential array out-of-bounds in
 encoder queue_setup

On Thu, Aug 10, 2023 at 4:23 PM Wei Chen <harperchen1110@...il.com> wrote:
>
> variable *nplanes is provided by user via system call argument. The
> possible value of q_data->fmt->num_planes is 1-3, while the value
> of *nplanes can be 1-8. The array access by index i can cause array
> out-of-bounds.
>
> Fix this bug by checking *nplanes against the array size.
>
> Fixes: 4e855a6efa54 ("[media] vcodec: mediatek: Add Mediatek V4L2 Video Encoder Driver")
> Signed-off-by: Wei Chen <harperchen1110@...il.com>
> Cc: stable@...r.kernel.org

Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>