linux-kernel - Re: [PATCH 1/3] arm64: dts: ti: k3-j721e: Enable C7x DSP nodes at the board level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ec8b817-e63f-3d76-894d-8af4f4e880db@ti.com>
Date:   Thu, 10 Aug 2023 14:20:37 +0530
From:   "Kumar, Udit" <u-kumar1@...com>
To:     Andrew Davis <afd@...com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>
CC:     <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j721e: Enable C7x DSP nodes at the
 board level

Thanks Andrew

On 8/9/2023 11:31 PM, Andrew Davis wrote:
> C7x DSP nodes defined in the top-level J721e SoC dtsi files are incomplete
> and will not be functional unless they are extended with both mboxes and
> memory-region information.
>
> As theses only known about at the board integration level, these nodes
> should only be enabled when provided with this information.
>
> Disable the C7x DSP nodes in the dtsi files and only enable the ones that
> are given the required mboxes and memory-region on a given board.
>
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>   arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts | 1 +
>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi          | 1 +
>   arch/arm64/boot/dts/ti/k3-j721e-sk.dts             | 1 +
>   arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi        | 1 +
>   4 files changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index 66aac145e7530..d1235e7c786d6 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -1024,6 +1024,7 @@ &c66_1 {
>   };
>   
>   &c71_0 {
> +	status = "okay";
>   	mboxes = <&mailbox0_cluster4>, <&mbox_c71_0>;
>   	memory-region = <&c71_0_dma_memory_region>,
>   			<&c71_0_memory_region>;

Series tested on J721E, J784S4 platforms

However I need to apply 
https://lore.kernel.org/linux-iommu/0-v2-d2762acaf50a+16d-iommu_group_locking2_jgg@nvidia.com/ 
patch


Tested-by: Udit Kumar <u-kumar1@...com>

https://gist.github.com/uditkumarti/b6320a06fadaaaf174fc0431949f11e1



> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 3acd55ffd4ffc..1aeb97b42b34b 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -2134,6 +2134,7 @@ c71_0: dsp@...00000 {
>   		ti,sci-proc-ids = <0x30 0xff>;
>   		resets = <&k3_reset 15 1>;
>   		firmware-name = "j7-c71_0-fw";
> +		status = "disabled";
>   	};
>   
>   	icssg0: icssg@...0000 {
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 0ee4f38ec8f03..377588ba30998 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -1110,6 +1110,7 @@ &c66_1 {
>   };
>   
>   &c71_0 {
> +	status = "okay";
>   	mboxes = <&mailbox0_cluster4>, <&mbox_c71_0>;
>   	memory-region = <&c71_0_dma_memory_region>,
>   			<&c71_0_memory_region>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> index e90e43202546e..3c31ab57e959c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi
> @@ -436,6 +436,7 @@ &c66_1 {
>   };
>   
>   &c71_0 {
> +	status = "okay";
>   	mboxes = <&mailbox0_cluster4>, <&mbox_c71_0>;
>   	memory-region = <&c71_0_dma_memory_region>,
>   			<&c71_0_memory_region>;