[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230810085632.xzonkmse27mu4yew@intel.intel>
Date: Thu, 10 Aug 2023 10:56:32 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Justin Stitt <justinstitt@...gle.com>
Cc: Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@...adcom.com>, linux-i2c@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
llvm@...ts.linux.dev, Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH 1/2] i2c: i2c-bcm-iproc: fix -Wvoid-pointer-to-enum-cast
warning
Hi Justin,
> @@ -1036,7 +1036,7 @@ static int bcm_iproc_i2c_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, iproc_i2c);
> iproc_i2c->device = &pdev->dev;
> iproc_i2c->type =
> - (enum bcm_iproc_i2c_type)of_device_get_match_data(&pdev->dev);
> + (unsigned long) of_device_get_match_data(&pdev->dev);
I think this should be uintptr_t, as defined in types.h:
typedef unsigned long uintptr_t;
(I'm a bit puzzled to see a void *data cast to a 0/1 value.)
Andi
Powered by blists - more mailing lists