linux-kernel - Re: [PATCH] thermal: broadcom: brcstb_thermal: removed unneeded platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3L5Qp3HYbaz3eWr7ugJ0Ftm+ji-3r376LeX23_qCHOq8Vvqg@mail.gmail.com>
Date:   Thu, 10 Aug 2023 13:27:54 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-pm@...r.kernel.org, florian.fainelli@...adcom.com,
        rui.zhang@...el.com, amitk@...nel.org, daniel.lezcano@...aro.org,
        rafael@...nel.org, bcm-kernel-feedback-list@...adcom.com,
        mmayer@...adcom.com
Subject: Re: [PATCH] thermal: broadcom: brcstb_thermal: removed unneeded platform_set_drvdata()

On Wed, Aug 9, 2023 at 6:48 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/thermal/broadcom/brcmstb_thermal.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/broadcom/brcmstb_thermal.c b/drivers/thermal/broadcom/brcmstb_thermal.c
> index 72d1dbe60b8f..2997c589ac7d 100644
> --- a/drivers/thermal/broadcom/brcmstb_thermal.c
> +++ b/drivers/thermal/broadcom/brcmstb_thermal.c
> @@ -334,7 +334,6 @@ static int brcmstb_thermal_probe(struct platform_device *pdev)
>                 return PTR_ERR(priv->tmon_base);
>
>         priv->dev = &pdev->dev;
> -       platform_set_drvdata(pdev, priv);
>         of_ops = priv->temp_params->of_ops;
>
>         thermal = devm_thermal_of_zone_register(&pdev->dev, 0, priv,
> --
> 2.34.1
>