[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20230810121354.2110227-1-ruanjinjie@huawei.com>
Date: Thu, 10 Aug 2023 20:13:54 +0800
From: Ruan Jinjie <ruanjinjie@...wei.com>
To: <arnd@...db.de>, <gregkh@...uxfoundation.org>,
<u.kleine-koenig@...gutronix.de>, <luca.ceresoli@...tlin.com>,
<jdelvare@...e.de>, <wsa+renesas@...g-engineering.com>,
<ruanjinjie@...wei.com>, <yuancan@...wei.com>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH -next] misc: eeprom/idt_89hpesx: Switch to memdup_user_nul() helper
Use memdup_user_nul() helper instead of open-coding to simplify the code.
Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
---
drivers/misc/eeprom/idt_89hpesx.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/misc/eeprom/idt_89hpesx.c b/drivers/misc/eeprom/idt_89hpesx.c
index 740c06382b83..433a4bc6b1c5 100644
--- a/drivers/misc/eeprom/idt_89hpesx.c
+++ b/drivers/misc/eeprom/idt_89hpesx.c
@@ -913,15 +913,9 @@ static ssize_t idt_dbgfs_csr_write(struct file *filep, const char __user *ubuf,
return 0;
/* Copy data from User-space */
- buf = kmalloc(count + 1, GFP_KERNEL);
- if (!buf)
- return -ENOMEM;
-
- if (copy_from_user(buf, ubuf, count)) {
- ret = -EFAULT;
- goto free_buf;
- }
- buf[count] = 0;
+ buf = memdup_user_nul(ubuf, count);
+ if (IS_ERR(buf))
+ return PTR_ERR(buf);
/* Find position of colon in the buffer */
colon_ch = strnchr(buf, count, ':');
--
2.34.1
Powered by blists - more mailing lists