linux-kernel - Re: [PATCH] HID: logitech-hidpp: Add support for Logitech MX Anywhere 3 mouse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <735d00afbc1a7fd2ede19cda76bcdc2bcc7d8212.camel@hadess.net>
Date:   Thu, 10 Aug 2023 14:17:57 +0200
From:   Bastien Nocera <hadess@...ess.net>
To:     Maxim Mikityanskiy <maxtram95@...il.com>,
        Filipe Laíns <lains@...eup.net>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: Add support for Logitech MX
 Anywhere 3 mouse

On Wed, 2023-08-09 at 14:38 +0300, Maxim Mikityanskiy wrote:
> Add Logitech MX Anywhere 3 connected over Bluetooth to the device
> table
> to get hidpi scroll supported. USB connection over the Unifying
> receiver
> is already supported by the wildcard entry LDJ_DEVICE(HID_ANY_ID).
> 
> Signed-off-by: Maxim Mikityanskiy <maxtram95@...il.com>

LGTM, thanks

Reviewed-by: Bastien Nocera <hadess@...ess.net>

> ---
>  drivers/hid/hid-logitech-hidpp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-
> logitech-hidpp.c
> index 129b01be488d..61d68c96581a 100644
> --- a/drivers/hid/hid-logitech-hidpp.c
> +++ b/drivers/hid/hid-logitech-hidpp.c
> @@ -4647,6 +4647,8 @@ static const struct hid_device_id
> hidpp_devices[] = {
>           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb02a) },
>         { /* MX Master 3 mouse over Bluetooth */
>           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb023) },
> +       { /* MX Anywhere 3 mouse over Bluetooth */
> +         HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb025) },
>         { /* MX Master 3S mouse over Bluetooth */
>           HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_LOGITECH, 0xb034) },
>         {}