linux-kernel - Re: [PATCH v6 0/7] Add TPS6594 PMIC support on several boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230810024700.4qhgygd6mma4sw2u@kobold>
Date:   Wed, 9 Aug 2023 21:47:00 -0500
From:   Nishanth Menon <nm@...com>
To:     Jai Luthra <j-luthra@...com>
CC:     Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Apurva Nandan <a-nandan@...com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Esteban Blanc <eblanc@...libre.com>, <jneanne@...libre.com>,
        <aseketeli@...libre.com>, <jpanis@...libre.com>, <u-kumar1@...com>,
        Vaishnav Achath <vaishnav.a@...com>,
        Hari Nagalla <hnagalla@...com>,
        Devarsh Thakkar <devarsht@...com>
Subject: Re: [PATCH v6 0/7] Add TPS6594 PMIC support on several boards

On 01:16-20230810, Jai Luthra wrote:
>  arch/arm64/boot/dts/ti/k3-am62a7-sk.dts          |  95 +++++++++++
>  arch/arm64/boot/dts/ti/k3-j7200-som-p0.dtsi      | 157 ++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-j721e-som-p0.dtsi      | 163 +++++++++++++++++++
>  arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi     | 199 +++++++++++++++++++++++

Sigh.. Thanks Jai for stepping and trying to make this work, but I think
this series is a lot out of whack. Apparently somewhere in this series
is a patch for j721s2 that breaks proper boot. I spent quite a while
bisecting across boards to find it, So, I am just going to skip this
series for this release (and dependencies)

Next time for this series: I recommend submitter provide test
logs for every single platform touched.

https://gist.github.com/nmenon/72e5f9b344e9207863d93491f5bf4f8e

I have'nt debugged, but typically that looks like some one decided to
pull the voltage low on a key rail.

Let me see if I can pick the interrupt range fix at least since
should'nt be dependent on this.

>  arch/arm64/boot/dts/ti/k3-j784s4-evm.dts         | 104 ++++++++++++
>  arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi       |   2 +-
>  arch/arm64/boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi |   2 +-
>  arch/arm64/configs/defconfig                     |   1 +
>  8 files changed, 721 insertions(+), 2 deletions(-)
> ---
> base-commit: 21ef7b1e17d039053edaeaf41142423810572741
> change-id: 20230809-tps6594-e450b5738e66
> 
> Best regards,
> -- 
> Jai Luthra <j-luthra@...com>
> 

bisect log: (commit sha's dont mean a thing.. but anyways..)
git bisect start
# good: [f2e72716f089d6fcc4bf7b8cb7ac874b79ed05b1] iommu: dev->iommu->iommu_dev must be set before ops->device_group()
git bisect good f2e72716f089d6fcc4bf7b8cb7ac874b79ed05b1
# bad: [31f83ee5e42290c39e0bce42118ad1267eaf2790] arm64: dts: ti: k3-am64: Enable TSCADC nodes at the board level
git bisect bad 31f83ee5e42290c39e0bce42118ad1267eaf2790
# bad: [f51a52fc98cddb7b99ecb19d86c40845f7e8d91e] arm64: dts: ti: k3-am62a7-sk: Split vcc_3v3 regulators
git bisect bad f51a52fc98cddb7b99ecb19d86c40845f7e8d91e
# good: [0cc1aecdc1024eced6914f015dbc43c28f5ac6aa] arm64: dts: ti: k3-j721s2-som-p0: Add TP6594 family PMICs
git bisect good 0cc1aecdc1024eced6914f015dbc43c28f5ac6aa
# good: [8b4e4f23f60df9c8aadb0e26cb86b13735ed810b] arm64: dts: ti: k3-j784s4-evm: Add support for TPS6594 PMIC
git bisect good 8b4e4f23f60df9c8aadb0e26cb86b13735ed810b
# bad: [38ff20140c2cf09ba140234732dd03a9743ebd32] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A
git bisect bad 38ff20140c2cf09ba140234732dd03a9743ebd32
# good: [3e98e865a6135bef7d801b5c5236a42a0ef1bff2] arm64: dts: ti: k3-am62a7-sk: Add support for TPS6593 PMIC
git bisect good 3e98e865a6135bef7d801b5c5236a42a0ef1bff2
# first bad commit: [38ff20140c2cf09ba140234732dd03a9743ebd32] arm64: defconfig: Enable TPS6593 PMIC for SK-AM62A

-- 

Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D