[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMo8BfJ5EBausUzk7u6LyNRm+Ybtbyg7LG0_hvYN30kZz8ECTg@mail.gmail.com>
Date: Thu, 10 Aug 2023 05:37:33 -0700
From: Max Filippov <jcmvbkbc@...il.com>
To: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
Cc: gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
linux-kernel@...r.kernel.org, Chris Zankel <chris@...kel.net>
Subject: Re: [PATCH 01/36] tty: xtensa/iss: drop unneeded tty_operations hooks
On Thu, Aug 10, 2023 at 2:15 AM Jiri Slaby (SUSE) <jirislaby@...nel.org> wrote:
>
> All ::flush_chars(), ::hangup(), and ::wait_until_sent() from struct
> tty_operations are optional. There is no need to provide them with
> empty bodies.
>
> tty_operations::put_char() needs not be provided if it is the same as
> tty_operations::write(tty, &ch, 1).
>
> So drop all of them.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> ---
> arch/xtensa/platforms/iss/console.c | 24 ------------------------
> 1 file changed, 24 deletions(-)
Acked-by: Max Filippov <jcmvbkbc@...il.com>
--
Thanks.
-- Max
Powered by blists - more mailing lists