linux-kernel - Re: [PATCH 2/2] ethernet: atarilance: mark init function static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e531089e-793c-6813-42d0-dfd9fffe61b8@huawei.com>
Date:   Thu, 10 Aug 2023 20:50:38 +0800
From:   Yang Yingliang <yangyingliang@...wei.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "Paolo Abeni" <pabeni@...hat.com>
CC:     Arnd Bergmann <arnd@...db.de>, Haoyue Xu <xuhaoyue1@...ilicon.com>,
        Guofeng Yue <yueguofeng@...ilicon.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ethernet: atarilance: mark init function static


On 2023/8/10 20:25, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> The init function is only referenced locally, so it should be static to
> avoid this warning:
>
> drivers/net/ethernet/amd/atarilance.c:370:28: error: no previous prototype for 'atarilance_probe' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Yang Yingliang <yangyingliang@...wei.com>