linux-kernel - Re: Subject: [PATCH] nlookup missing decrement in fuse_direntplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJfpegtjQxPd-nncaf+7pvowSJHx+2mLgOZBJuCLXetnSCuqog@mail.gmail.com>
Date:   Thu, 10 Aug 2023 16:15:23 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     ruan.meisi@....com.cn
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Subject: [PATCH] nlookup missing decrement in fuse_direntplus_link

On Thu, 10 Aug 2023 at 05:25, <ruan.meisi@....com.cn> wrote:
>
>
> From 53aad83672123dbe01bcef9f9026becc4e93ee9f Mon Sep 17 00:00:00 2001
>
> From: ruanmeisi <ruan.meisi@....com.cn>
>
> Date: Tue, 25 Apr 2023 19:13:54 +0800
>
> Subject: [PATCH] nlookup missing decrement in fuse_direntplus_link
>
>
> During our debugging of glusterfs, we found an Assertion
>
> failed error: inode_lookup >= nlookup, which was caused by the
>
> nlookup value in the kernel being greater than that in the FUSE
>
> file system.The issue was introduced by fuse_direntplus_link,
>
> where in the function, fuse_iget increments nlookup, and if
>
> d_splice_alias returns failure, fuse_direntplus_link returns
>
> failure without decrementing nlookup
>
> https://github.com/gluster/glusterfs/pull/4081
>
>
> Signed-off-by: ruanmeisi <ruan.meisi@....com.cn>

Thanks.   Patch looks good.

Please resend as plain text otherwise the mailing lists will reject it
and also tools will fail to handle it, so it can't be applied.

If you can't send as plain text, sending as an attachment is still better.

Thanks,
Miklos