linux-kernel - Re: [PATCH 05/17] swim3: mark swim3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffEkM4XKn4MRNR332wENzWzjX=ujWu1HH_zdeGqGB+D79tQ@mail.gmail.com>
Date:   Thu, 10 Aug 2023 16:26:58 +0200
From:   Jinpu Wang <jinpu.wang@...os.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Arnd Bergmann <arnd@...db.de>,
        Christian Brauner <brauner@...nel.org>,
        Hannes Reinecke <hare@...e.de>, linux-block@...r.kernel.org
Subject: Re: [PATCH 05/17] swim3: mark swim3_init() static

On Thu, Aug 10, 2023 at 4:21 PM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> This is the module init function, which by definition is used only
> locally, so mark it static to avoid a warning:
>
> drivers/block/swim3.c:1280:5: error: no previous prototype for 'swim3_init' [-Werror=missing-prototypes]
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
lgtm
Reviewed-by: Jack Wang <jinpu.wang@...os.com>
> ---
>  drivers/block/swim3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/swim3.c b/drivers/block/swim3.c
> index dc43a63b34694..c2bc85826358e 100644
> --- a/drivers/block/swim3.c
> +++ b/drivers/block/swim3.c
> @@ -1277,7 +1277,7 @@ static struct macio_driver swim3_driver =
>  };
>
>
> -int swim3_init(void)
> +static int swim3_init(void)
>  {
>         macio_register_driver(&swim3_driver);
>         return 0;
> --
> 2.39.2
>