linux-kernel - Re: [PATCH 1/2] iio: lsm6dsx: Support temperature channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYHMyfvAGxgvtB8jgTsOp36Lm4gXzVYcBfXdY7RQK36cQ@mail.gmail.com>
Date:   Fri, 11 Aug 2023 20:16:23 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Mario Tesi <mario.tesi@...com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] iio: lsm6dsx: Support temperature channel

Hi Lorenzo!

thanks for the review!

On Fri, Aug 11, 2023 at 12:07 PM Lorenzo Bianconi <lorenzo@...nel.org> wrote:

> > +                     [ST_LSM6DSX_ID_TEMP] = {
> > +                             .reg = {
> > +                                     .addr = 0x0A,
> > +                                     .mask = GENMASK(5, 4),
> > +                             },
>
> looking at the ISM330DHCX datasheet, the temperature sensor ODR is just 52Hz,
> while values in 0x0A register are used only for FIFO decimation, they are not
> values you can configure the sensor e.g. for read_one_shot().
>
> > +                             .odr_avl[0] = {  26000, 0x02 },
> > +                             .odr_avl[1] = {  52000, 0x03 },
> > +                             .odr_len = 2,

I look at page 44, paragraph 9.6 about bits 4-5:

ODR_T_BATCH_[1:0]
Selects batch data rate (write frequency in FIFO) for temperature data
(00: Temperature not batched in FIFO (default);
01: 1.6 Hz;
10: 12.5 Hz;
11: 52 Hz)

That reads to me that I should actually add the odr for 1.6 and 12.5 Hz
and the above 26 Hz is wrong but the .odr_avl[1] = {  52000, 0x03 },
52000 milli-Hz is fine?

Yours,
Linus Walleij