linux-kernel - Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOX2RU6X0Tww4UkTKVfc=PLY=RKVJdsm+gomytT0vOydTF+Hnw@mail.gmail.com>
Date:   Fri, 11 Aug 2023 23:35:47 +0200
From:   Robert Marko <robimarko@...il.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>
Cc:     agross@...nel.org, andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node
 with bindings

On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
> On 11.08.2023 23:01, Robert Marko wrote:
> > Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
> > as they should be under the partitions subnode and use the generic
> > jedec,spi-nor compatible.
> >
> > Signed-off-by: Robert Marko <robimarko@...il.com>
> > ---
> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"

Hi,
I grepped the vendor U-Boot to make sure it's not being triggered off
the mx25l25635e
compatible but the only hit is the IC support itself.
MX25L25635 was just the original NOR IC Qualcomm used on the board so
to me it made
most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR
compatible.

Regards,
Robert
>
> Konrad
>
> >  arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi b/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi
> > index 0714616c9e45..f7ac8f9d0b6f 100644
> > --- a/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi
> > +++ b/arch/arm/boot/dts/qcom/qcom-ipq4019-ap.dk01.1.dtsi
> > @@ -75,11 +75,9 @@ &blsp1_spi1 {
> >       status = "okay";
> >       cs-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
> >
> > -     mx25l25635e@0 {
> > -             #address-cells = <1>;
> > -             #size-cells = <1>;
> > +     flash@0 {
> >               reg = <0>;
> > -             compatible = "mx25l25635e";
> > +             compatible = "jedec,spi-nor";
> >               spi-max-frequency = <24000000>;
> >       };
> >  };