[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2e263977-0ee7-ae78-5a8a-2a67df43df76@acm.org>
Date: Fri, 11 Aug 2023 15:06:08 -0700
From: Bart Van Assche <bvanassche@....org>
To: Nitesh Shetty <nj.shetty@...sung.com>,
Jens Axboe <axboe@...nel.dk>, Jonathan Corbet <corbet@....net>,
Alasdair Kergon <agk@...hat.com>,
Mike Snitzer <snitzer@...nel.org>, dm-devel@...hat.com,
Keith Busch <kbusch@...nel.org>,
Christoph Hellwig <hch@....de>,
Sagi Grimberg <sagi@...mberg.me>,
Chaitanya Kulkarni <kch@...dia.com>,
Alexander Viro <viro@...iv.linux.org.uk>,
Christian Brauner <brauner@...nel.org>
Cc: martin.petersen@...cle.com, linux-doc@...r.kernel.org,
gost.dev@...sung.com, Anuj Gupta <anuj20.g@...sung.com>,
linux-kernel@...r.kernel.org, linux-nvme@...ts.infradead.org,
linux-block@...r.kernel.org, mcgrof@...nel.org, dlemoal@...nel.org,
linux-fsdevel@...r.kernel.org
Subject: Re: [dm-devel] [PATCH v14 03/11] block: add copy offload support
On 8/11/23 03:52, Nitesh Shetty wrote:
> + if (rem != chunk)
> + atomic_inc(&cio->refcount);
This code will be easier to read if the above if-test is left out
and if the following code is added below the for-loop:
if (atomic_dec_and_test(&cio->refcount))
blkdev_copy_endio(cio);
Thanks,
Bart.
Powered by blists - more mailing lists