linux-kernel - Re: [PATCH 3/7] ARM: dts: qcom: add device tree for Nokia Lumia 630

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Aug 2023 01:03:00 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Rayyan Ansari <rayyan@...ari.sh>, linux-arm-msm@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht,
        Dominik Kobinski <dominikkobinski314@...il.com>,
        Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>,
        Jack Matthews <jm5112356@...il.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH 3/7] ARM: dts: qcom: add device tree for Nokia Lumia 630

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Nokia Lumia 630, codenamed
> "moneypenny".
> 
> Co-authored-by: Dominik Kobinski <dominikkobinski314@...il.com>
> Co-authored-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> Co-authored-by: Jack Matthews <jm5112356@...il.com>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@...il.com>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> Signed-off-by: Jack Matthews <jm5112356@...il.com>
> Signed-off-by: Rayyan Ansari <rayyan@...ari.sh>
> ---
>  arch/arm/boot/dts/qcom/Makefile               |  1 +
>  .../qcom-msm8226-microsoft-moneypenny.dts     | 23 +++++++++++++++++++
>  2 files changed, 24 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
> 
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 3dfb1c8cefb8..b2569059ce8d 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>  	qcom-ipq4019-ap.dk07.1-c2.dtb \
>  	qcom-ipq8064-ap148.dtb \
>  	qcom-ipq8064-rb3011.dtb \
> +	qcom-msm8226-microsoft-moneypenny.dtb \
>  	qcom-msm8226-samsung-s3ve3g.dtb \
>  	qcom-msm8660-surf.dtb \
>  	qcom-msm8916-samsung-e5.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
> new file mode 100644
> index 000000000000..e13e018a6759
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8226-microsoft-moneypenny.dts
> @@ -0,0 +1,23 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Jack Matthews <jm5112356@...il.com>
> + * Copyright (c) 2023, Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
> + * Copyright (c) 2023, Dominik Kobinski <dominikkobinski314@...il.com>
> + * Copyright (c) 2023, Rayyan Ansari <rayyan@...ari.sh>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-microsoft-common.dtsi"
> +
> +/ {
> +	model = "Nokia Lumia 630";
> +	compatible = "microsoft,moneypenny", "qcom,msm8226";
> +	chassis-type = "handset";
> +};
> +
> +&framebuffer0 {
Guess s/framebuffer0/framebuffer would be in order

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad