[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230811051121.GL11676@atomide.com>
Date: Fri, 11 Aug 2023 08:11:21 +0300
From: Tony Lindgren <tony@...mide.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>, Dhruva Gole <d-gole@...com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
John Ogness <john.ogness@...utronix.de>,
Johan Hovold <johan@...nel.org>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Vignesh Raghavendra <vigneshr@...com>,
linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] serial: core: Fix serial core port id, including
multiport devices
* Andy Shevchenko <andriy.shevchenko@...el.com> [230810 15:26]:
> On Thu, Aug 10, 2023 at 06:24:13PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote:
>
> ...
>
> > > + unsigned int min = 0, max = ~0U;
> >
> > Shouldn't this be int? The max IIRC will be INT_MAX with this anyway.
>
> Ah, and then you can supply is as 0 (IIRC).
The returned id will be INT_MAX, but idr.h uses unsigned int:
int ida_alloc_range(struct ida *, unsigned int min, unsigned int max, gfp_t);
If there's some reason to limit max id we can do it, otherwise it's just
a don't care flag.
Please clarify if I'm not following what you are suggesting :)
Regards,
Tony
Powered by blists - more mailing lists