linux-kernel - Re: [PATCH] thermal: broadcom: sr-thermal: removed call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Aug 2023 08:55:11 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        hayashi.kunihiko@...ionext.com, bchihi@...libre.com,
        rui.zhang@...el.com, amitk@...nel.org, daniel.lezcano@...aro.org,
        rafael@...nel.org
Subject: Re: [PATCH] thermal: broadcom: sr-thermal: removed call to platform_set_drvdata()

On Thu, Aug 10, 2023 at 2:13 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

I had to take a look over how "thermal_zone_device_priv()" works, and
it looks like it has nothing to do with the platform_set_drvdata() /
dev_set_drvdata() / dev->driver_data stuff.
It defines it's own `devdata` pointer.
Though, it looks like "thermal_zone_device_priv()" could potentially
be converted to use "dev->driver_data"
But that requires a bit of going through all drivers to convert them.

Anyway, for this:

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/thermal/broadcom/sr-thermal.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/broadcom/sr-thermal.c b/drivers/thermal/broadcom/sr-thermal.c
> index 747915890022..9a29dfd4c7fe 100644
> --- a/drivers/thermal/broadcom/sr-thermal.c
> +++ b/drivers/thermal/broadcom/sr-thermal.c
> @@ -91,7 +91,6 @@ static int sr_thermal_probe(struct platform_device *pdev)
>
>                 dev_dbg(dev, "thermal sensor %d registered\n", i);
>         }
> -       platform_set_drvdata(pdev, sr_thermal);
>
>         return 0;
>  }
> --
> 2.34.1
>