linux-kernel - Re: [PATCH] thermal: k3_j72xx_bandgap: removed unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3L5QqXMAmiiDF5cNM9fY68hiqXeH6GKHdrQYG5Mh9H9Nrc3w@mail.gmail.com>
Date:   Fri, 11 Aug 2023 08:57:24 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        rui.zhang@...el.com, amitk@...nel.org, daniel.lezcano@...aro.org,
        rafael@...nel.org
Subject: Re: [PATCH] thermal: k3_j72xx_bandgap: removed unneeded call to platform_set_drvdata()

On Thu, Aug 10, 2023 at 2:20 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/thermal/k3_j72xx_bandgap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
> index 5be1f09eeb2c..b91743dbd95a 100644
> --- a/drivers/thermal/k3_j72xx_bandgap.c
> +++ b/drivers/thermal/k3_j72xx_bandgap.c
> @@ -502,8 +502,6 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
>         writel(K3_VTM_ANYMAXT_OUTRG_ALERT_EN, data[0].bgp->cfg2_base +
>                K3_VTM_MISC_CTRL_OFFSET);
>
> -       platform_set_drvdata(pdev, bgp);
> -
>         print_look_up_table(dev, ref_table);
>         /*
>          * Now that the derived_table has the appropriate look up values
> --
> 2.34.1
>