[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87r0oadquu.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
Date: Fri, 11 Aug 2023 12:10:09 +0530
From: Kamlesh Gurudasani <kamlesh@...com>
To: Eric Biggers <ebiggers@...nel.org>
CC: Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
Rob Herring <robh+dt@...nel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Nishanth Menon <nm@...com>,
Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
<linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [EXTERNAL] Re: [PATCH v2 2/6] crypto: crc64 - add crc64-iso
framework
Eric Biggers <ebiggers@...nel.org> writes:
> On Fri, Aug 11, 2023 at 12:58:49AM +0530, Kamlesh Gurudasani wrote:
>> diff --git a/lib/crc64-iso.c b/lib/crc64-iso.c
>> new file mode 100644
>> index 000000000000..d6e803124fa0
> [...]
>> +u64 crc64_iso_update(u64 crc, const unsigned char *buffer, size_t len)
>> +{
>> + struct {
>> + struct shash_desc shash;
>> + u64 crc;
>> + } desc;
>> + int err;
>> +
>> + if (static_branch_unlikely(&crc64_iso_fallback))
>> + return crc64_iso_generic(crc, buffer, len);
>> +
>> + rcu_read_lock();
>> + desc.shash.tfm = rcu_dereference(crc64_iso_tfm);
>> + desc.crc = crc;
>> + err = crypto_shash_update(&desc.shash, buffer, len);
>> + rcu_read_unlock();
>> +
>> + WARN_ON_ONCE(err);
>> +
>> + return desc.crc;
>> +}
>> +EXPORT_SYMBOL_GPL(crc64_iso_update);
>> +
>> +u64 crc64_iso(const unsigned char *buffer, size_t len)
>> +{
>> + return crc64_iso_update(0, buffer, len);
>> +}
>> +EXPORT_SYMBOL_GPL(crc64_iso);
>
> These functions are never called.
>
> Why are you trying to add unused code to the kernel?
>
> - Eric
Thanks for the review, Eric.
Will remove this in next revision.
Regards,
Kamlesh
Powered by blists - more mailing lists