linux-kernel - Re: [PATCH] csky: Fixup -Wmissing-prototypes warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <cf25b0f4-ee4b-40bd-a928-afdc4cad5c2e@app.fastmail.com>
Date:   Fri, 11 Aug 2023 09:32:59 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     guoren <guoren@...nel.org>
Cc:     "linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        Linux-Arch <linux-arch@...r.kernel.org>,
        "Guo Ren" <guoren@...ux.alibaba.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Subject: Re: [PATCH] csky: Fixup -Wmissing-prototypes warning

On Fri, Aug 11, 2023, at 05:07, guoren@...nel.org wrote:
>
> Link: https://lore.kernel.org/lkml/20230810141947.1236730-17-arnd@kernel.org/
> Reported-by: Arnd Bergmann <arnd@...nel.org>
> Signed-off-by: Guo Ren <guoren@...ux.alibaba.com>
> Signed-off-by: Guo Ren <guoren@...nel.org>

Thanks for addressing these!

Reviewed-by: Arnd Bergmann <arnd@...db.de>

> --- a/arch/csky/kernel/vdso/vgettimeofday.c
> +++ b/arch/csky/kernel/vdso/vgettimeofday.c
> @@ -3,24 +3,35 @@
>  #include <linux/time.h>
>  #include <linux/types.h>
> 
> +extern
> +int __vdso_clock_gettime(clockid_t clock,
> +			 struct old_timespec32 *ts);
>  int __vdso_clock_gettime(clockid_t clock,
>  			 struct old_timespec32 *ts)
>  {
>  	return __cvdso_clock_gettime32(clock, ts);
>  }
> 

This works, but it would be a bit nicer to move the
declarations into a header. I see that we already handle
this in three different ways across x86, arm and arm64,
and you picked method from x86 (and loongarch) here, so
I can't really complain.

What we should probably have instead is a new header
in include/vdso/ that  declares the functions for
every architecture.

      Arnd