linux-kernel - Re: [PATCH net-next v4 2/4] net: tcp: allow zero-window ACK update the window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL_ajkpP3AX26Eieevp4ZwVUCfbVX8Xge-Bc9G3SfBdcA@mail.gmail.com>
Date:   Fri, 11 Aug 2023 09:37:56 +0200
From:   Eric Dumazet <edumazet@...gle.com>
To:     menglong8.dong@...il.com
Cc:     ncardwell@...gle.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, dsahern@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, flyingpeng@...cent.com,
        Menglong Dong <imagedong@...cent.com>
Subject: Re: [PATCH net-next v4 2/4] net: tcp: allow zero-window ACK update
 the window

On Fri, Aug 11, 2023 at 5:01 AM <menglong8.dong@...il.com> wrote:
>
> From: Menglong Dong <imagedong@...cent.com>
>
> Fow now, an ACK can update the window in following case, according to
> the tcp_may_update_window():
>
> 1. the ACK acknowledged new data
> 2. the ACK has new data
> 3. the ACK expand the window and the seq of it is valid
>
> Now, we allow the ACK update the window if the window is 0, and the
> seq/ack of it is valid. This is for the case that the receiver replies
> an zero-window ACK when it is under memory stress and can't queue the new
> data.
>
> Signed-off-by: Menglong Dong <imagedong@...cent.com>

Reviewed-by: Eric Dumazet <edumazet@...gle.com>