linux-kernel - Re: [PATCH] media: rc: ir-spi: Correct regulator name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNYF/iGqrBQrV3IT@gofer.mess.org>
Date:   Fri, 11 Aug 2023 10:57:18 +0100
From:   Sean Young <sean@...s.org>
To:     wuxilin123@...il.com
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH] media: rc: ir-spi: Correct regulator name

On Sat, Aug 05, 2023 at 07:23:35PM +0800, Xilin Wu via B4 Relay wrote:
> From: Xilin Wu <wuxilin123@...il.com>
> 
> The driver wrongly assumes regulator is called "irda_regulator"
> instead of "power".
> 
> Change it to "power" to match device tree binding.
> 
> Signed-off-by: Xilin Wu <wuxilin123@...il.com>
> ---
>  drivers/media/rc/ir-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
> index bbc81bed4f90..a447bb36100d 100644
> --- a/drivers/media/rc/ir-spi.c
> +++ b/drivers/media/rc/ir-spi.c
> @@ -119,7 +119,7 @@ static int ir_spi_probe(struct spi_device *spi)
>  	if (!idata)
>  		return -ENOMEM;
>  
> -	idata->regulator = devm_regulator_get(&spi->dev, "irda_regulator");
> +	idata->regulator = devm_regulator_get(&spi->dev, "power");

I agree that irda_regulator is not a great name and it probably should have
been picked up in review. However, is it safe to change without breaking
backwards compatibility?

Rob, what do you think?

Thanks
Sean

>  	if (IS_ERR(idata->regulator))
>  		return PTR_ERR(idata->regulator);
>  
> 
> ---
> base-commit: 024ff300db33968c133435a146d51ac22db27374
> change-id: 20230805-ir-spi-3473c5f34764
> 
> Best regards,
> -- 
> Xilin Wu <wuxilin123@...il.com>