linux-kernel - [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10 PI verify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Aug 2023 21:03:12 +0530
From:   Ankit Kumar <ankit.kumar@...sung.com>
To:     Jens Axboe <axboe@...nel.dk>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Keith Busch <kbusch@...nel.org>
Cc:     gost.dev@...sung.com, Ankit Kumar <ankit.kumar@...sung.com>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/2] block:t10-pi: remove redundant Type2 check during t10
 PI verify

T10_PI_TYPE2_PROTECTION is neither used to generate nor verify
crc and ip. Remove this redundant check.

Signed-off-by: Ankit Kumar <ankit.kumar@...sung.com>
---
 block/t10-pi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/t10-pi.c b/block/t10-pi.c
index 914d8cddd43a..bf0bba01417f 100644
--- a/block/t10-pi.c
+++ b/block/t10-pi.c
@@ -64,8 +64,7 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter,
 		struct t10_pi_tuple *pi = iter->prot_buf;
 		__be16 csum;
 
-		if (type == T10_PI_TYPE1_PROTECTION ||
-		    type == T10_PI_TYPE2_PROTECTION) {
+		if (type == T10_PI_TYPE1_PROTECTION) {
 			if (pi->app_tag == T10_PI_APP_ESCAPE)
 				goto next;
 
-- 
2.25.1