linux-kernel - Re: [PATCH v6 4/4] iommufd/selftest: Add coverage for IOMMU_GET_HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNYjEFpN7iZcM0sE@nvidia.com>
Date:   Fri, 11 Aug 2023 09:01:20 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     "Liu, Yi L" <yi.l.liu@...el.com>
Cc:     "joro@...tes.org" <joro@...tes.org>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "cohuck@...hat.com" <cohuck@...hat.com>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "nicolinc@...dia.com" <nicolinc@...dia.com>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "mjrosato@...ux.ibm.com" <mjrosato@...ux.ibm.com>,
        "chao.p.peng@...ux.intel.com" <chao.p.peng@...ux.intel.com>,
        "yi.y.sun@...ux.intel.com" <yi.y.sun@...ux.intel.com>,
        "peterx@...hat.com" <peterx@...hat.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "shameerali.kolothum.thodi@...wei.com" 
        <shameerali.kolothum.thodi@...wei.com>,
        "lulu@...hat.com" <lulu@...hat.com>,
        "suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
        "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kselftest@...r.kernel.org" <linux-kselftest@...r.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@...el.com>
Subject: Re: [PATCH v6 4/4] iommufd/selftest: Add coverage for
 IOMMU_GET_HW_INFO ioctl

On Fri, Aug 11, 2023 at 06:57:34AM +0000, Liu, Yi L wrote:
> > From: Jason Gunthorpe <jgg@...dia.com>
> > Sent: Thursday, August 10, 2023 12:46 AM
> > 
> > On Tue, Aug 08, 2023 at 08:35:10AM -0700, Yi Liu wrote:
> > > From: Nicolin Chen <nicolinc@...dia.com>
> > >
> > > Add a mock_domain_hw_info function and an iommu_test_hw_info data
> > > structure. This allows to test the IOMMU_GET_HW_INFO ioctl passing
> > > the test_reg value for the mock_dev.
> > >
> > > Signed-off-by: Nicolin Chen <nicolinc@...dia.com>
> > > Signed-off-by: Yi Liu <yi.l.liu@...el.com>
> > > ---
> > >  drivers/iommu/iommufd/iommufd_test.h          |  9 +++++++
> > >  drivers/iommu/iommufd/selftest.c              | 16 ++++++++++++
> > >  tools/testing/selftests/iommu/iommufd.c       | 17 +++++++++++-
> > >  tools/testing/selftests/iommu/iommufd_utils.h | 26 +++++++++++++++++++
> > >  4 files changed, 67 insertions(+), 1 deletion(-)
> > 
> > Don't forget to add it to fail_nth
> 
> Sure. Btw. Would you share us the rule on determining whether an ioctl/path
> requires fail_nth case or not.

It always requires it :)

Jason