linux-kernel - Re: [PATCH 2/2] arm64: dts: mediatek: fix t-phy unit name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6317dfe358f0181aaac3fc4a9d6207a5a7d7efe8.camel@collabora.com>
Date:   Fri, 11 Aug 2023 14:10:15 +0100
From:   Christopher Obbard <chris.obbard@...labora.com>
To:     Eugen Hristev <eugen.hristev@...labora.com>,
        linux-mediatek@...ts.infradead.org
Cc:     krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, conor+dt@...nel.org,
        kernel@...labora.com
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: fix t-phy unit name

Hi Eugen,

On Fri, 2023-08-11 at 16:07 +0300, Eugen Hristev wrote:
> Fix:
> Warning (unit_address_vs_reg): /t-phy@...43000: node has a unit name, but no reg or ranges property
> Warning (unit_address_vs_reg): /soc/t-phy@...00000: node has a unit name, but no reg or ranges property
> 
> The ranges is empty thus removing the `@...43000`, `@...00000` from
> the node name.

Does this patch need a Fixes: tag?
It would be also quite nice to say in your commit messsage where the error comes from (make dtbs_check) :-)

> 
> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com>
> ---
>  arch/arm64/boot/dts/mediatek/mt7622.dtsi  | 2 +-
>  arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 36ef2dbe8add..3ee9266fa8e9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -905,7 +905,7 @@ sata: sata@...00000 {
>  		status = "disabled";
>  	};
>  
> -	sata_phy: t-phy@...43000 {
> +	sata_phy: t-phy {
>  		compatible = "mediatek,mt7622-tphy",
>  			     "mediatek,generic-tphy-v1";
>  		#address-cells = <2>;
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> index 68539ea788df..24eda00e320d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi
> @@ -434,7 +434,7 @@ pcie_intc: interrupt-controller {
>  			};
>  		};
>  
> -		pcie_phy: t-phy@...00000 {
> +		pcie_phy: t-phy {
>  			compatible = "mediatek,mt7986-tphy",
>  				     "mediatek,generic-tphy-v2";
>  			#address-cells = <2>;
> -- 
> 2.34.1