[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNY-IhuJJMZuFAHz@alley>
Date: Fri, 11 Aug 2023 15:56:50 +0200
From: Petr Mladek <pmladek@...e.com>
To: John Ogness <john.ogness@...utronix.de>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
Steven Rostedt <rostedt@...dmis.org>,
Thomas Gleixner <tglx@...utronix.de>,
linux-kernel@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH printk v2 0/8] wire up nbcon consoles
On Fri 2023-07-28 02:08:25, John Ogness wrote:
> Hi,
>
> This is v2 of a series to introduce the new non-BKL (nbcon)
> consoles. This series is only a subset of the original
> v1 [0]. In particular, this series represents patches 5-10 of
> the v1 series. For information about the motivation of the
> atomic consoles, please read the cover letter of v1.
>
> This series focuses on wiring up the printk subsystem to
> be able to use the nbcon consoles and implement their ownership
> interfaces and rules. This series does _not_ include threaded
> printing, atomic printing regions, or nbcon drivers. Those
> features will be added in separate follow-up series.
>
>
> include/linux/console.h | 132 +++++
> kernel/printk/Makefile | 2 +-
> kernel/printk/internal.h | 29 ++
> kernel/printk/printk.c | 156 ++++--
> kernel/printk/printk_nbcon.c | 955 +++++++++++++++++++++++++++++++++++
Nit: Is there still any chance to rename this to kernel/printk/nbcon.c ?
I am sorry that I did not suggested this earlier. I think that
we should have omitted the "printk_" prefix even for
the "ringbuffer.*" files.
I think that it came from "printk_safe.c". But it made some sense.
"printk_safe_*" was also an API.
But in general, "printk_" prefix is superfluous in "printk" directory.
Best Regards,
Petr
Powered by blists - more mailing lists