linux-kernel - Re: [PATCH] gpio: mxs: fix Wvoid-pointer-to-enum-cast warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MccHyVtv10YVbsP7x5zSsFYiPTKbTsSaqEPWKp7ewHtPA@mail.gmail.com>
Date:   Fri, 11 Aug 2023 16:22:06 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andy@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PATCH] gpio: mxs: fix Wvoid-pointer-to-enum-cast warning

On Thu, Aug 10, 2023 at 11:59 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> 'devid' is an enum, thus cast of pointer on 64-bit compile test with W=1
> causes:
>
>   gpio-mxs.c:274:16: error: cast to smaller integer type 'enum mxs_gpio_id' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  drivers/gpio/gpio-mxs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c
> index 8e04c9c4b5a2..024ad077e98d 100644
> --- a/drivers/gpio/gpio-mxs.c
> +++ b/drivers/gpio/gpio-mxs.c
> @@ -271,7 +271,7 @@ static int mxs_gpio_probe(struct platform_device *pdev)
>         port->id = of_alias_get_id(np, "gpio");
>         if (port->id < 0)
>                 return port->id;
> -       port->devid = (enum mxs_gpio_id)of_device_get_match_data(&pdev->dev);
> +       port->devid = (uintptr_t)of_device_get_match_data(&pdev->dev);
>         port->dev = &pdev->dev;
>         port->irq = platform_get_irq(pdev, 0);
>         if (port->irq < 0)
> --
> 2.34.1
>

Applied, thanks!

Bart