linux-kernel - Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <13f9c06a-f840-4010-ae2f-97d8b2883e76@app.fastmail.com>
Date:   Sat, 12 Aug 2023 10:02:07 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Stafford Horne" <shorne@...il.com>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     "Andrew Morton" <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, "Matt Turner" <mattst88@...il.com>,
        "Vineet Gupta" <vgupta@...nel.org>,
        "Russell King" <linux@...linux.org.uk>,
        "Catalin Marinas" <catalin.marinas@....com>,
        "Will Deacon" <will@...nel.org>, guoren <guoren@...nel.org>,
        "Brian Cain" <bcain@...cinc.com>,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "WANG Xuerui" <kernel@...0n.name>,
        "Geert Uytterhoeven" <geert@...ux-m68k.org>,
        "Michal Simek" <monstr@...str.eu>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Dinh Nguyen" <dinguyen@...nel.org>,
        "Jonas Bonn" <jonas@...thpole.se>,
        "James E . J . Bottomley" <James.Bottomley@...senpartnership.com>,
        "Helge Deller" <deller@....de>,
        "Michael Ellerman" <mpe@...erman.id.au>,
        "Christophe Leroy" <christophe.leroy@...roup.eu>,
        "Palmer Dabbelt" <palmer@...belt.com>,
        "Heiko Carstens" <hca@...ux.ibm.com>,
        "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
        x86@...nel.org, "Borislav Petkov" <bp@...en8.de>,
        "Nathan Chancellor" <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        "Guenter Roeck" <linux@...ck-us.net>,
        "Stephen Rothwell" <sfr@...b.auug.org.au>,
        linux-next <linux-next@...r.kernel.org>,
        linux-alpha@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        "linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>,
        linux-hexagon@...r.kernel.org, linux-ia64@...r.kernel.org,
        loongarch@...ts.linux.dev, linux-m68k@...ts.linux-m68k.org,
        linux-mips@...r.kernel.org,
        "linux-openrisc@...r.kernel.org" <linux-openrisc@...r.kernel.org>,
        sparclinux@...r.kernel.org,
        "Richard Henderson" <richard.henderson@...aro.org>,
        "Ivan Kokshaysky" <ink@...assic.park.msu.ru>,
        "Stefan Kristiansson" <stefan.kristiansson@...nalahti.fi>,
        "Yoshinori Sato" <ysato@...rs.sourceforge.jp>,
        "Rich Felker" <dalias@...c.org>,
        "David S . Miller" <davem@...emloft.net>,
        "Chris Zankel" <chris@...kel.net>,
        "Max Filippov" <jcmvbkbc@...il.com>,
        "Christian Brauner" <brauner@...nel.org>,
        "Paul Walmsley" <paul.walmsley@...ive.com>,
        "Albert Ou" <aou@...s.berkeley.edu>,
        "Youling Tang" <tangyouling@...ngson.cn>,
        "Tiezhu Yang" <yangtiezhu@...ngson.cn>,
        "Masahiro Yamada" <masahiroy@...nel.org>,
        "Randy Dunlap" <rdunlap@...radead.org>,
        "Masami Hiramatsu" <mhiramat@...nel.org>,
        "Paul E. McKenney" <paulmck@...nel.org>,
        "Miguel Ojeda" <ojeda@...nel.org>,
        "Zhen Lei" <thunder.leizhen@...wei.com>,
        "Xin Li" <xin3.li@...el.com>, "Nhat Pham" <nphamcs@...il.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Marc Aurèle La France <tsi@...oix.net>,
        "Johannes Weiner" <hannes@...xchg.org>,
        linux-parisc@...r.kernel.org, linux-sh@...r.kernel.org,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 16/17] [RFC] arch: turn -Wmissing-prototypes off conditionally

On Fri, Aug 11, 2023, at 22:09, Stafford Horne wrote:
> On Thu, Aug 10, 2023 at 04:19:34PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>

>> arch/openrisc/mm/fault.c:44:17: error: no previous prototype for 'do_page_fault' [-Werror=missing-prototypes]
>> arch/openrisc/mm/tlb.c:188:13: error: no previous prototype for 'tlb_init' [-Werror=missing-prototypes]
>
> I'll try to get these fixed for 6.6.  I was looking at them recently but did not
> actually make any changes and just put on my TODO.  Your series moves it up in
> priority and it should be easy to get the fixes out.

Thanks!

Since we already have the majority of architecture maintainers stepping
in to fix the warnings, I wonder if I should just drop my patch 16/17
completely and let the others handle it as well rather than shutting up
the warnings. Only the asm-offsets change is really needed to compile
test most of the kernel even with CONFIG_WERROR, and without that this
is just some harmless output.

    Arnd