linux-kernel - Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <389904f7-86fa-48be-ba30-aa8cfeb44353@linaro.org>
Date:   Sat, 12 Aug 2023 16:08:35 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Robert Marko <robimarko@...il.com>
Cc:     agross@...nel.org, andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node
 with bindings

On 12.08.2023 16:07, Robert Marko wrote:
> On Sat, 12 Aug 2023 at 12:47, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>
>> On 12.08.2023 11:55, Robert Marko wrote:
>>> On Sat, 12 Aug 2023 at 00:56, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>>>
>>>> On 11.08.2023 23:35, Robert Marko wrote:
>>>>> On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>>>>>
>>>>>> On 11.08.2023 23:01, Robert Marko wrote:
>>>>>>> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
>>>>>>> as they should be under the partitions subnode and use the generic
>>>>>>> jedec,spi-nor compatible.
>>>>>>>
>>>>>>> Signed-off-by: Robert Marko <robimarko@...il.com>
>>>>>>> ---
>>>>>> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"
>>>>>
>>>>> Hi,
>>>>> I grepped the vendor U-Boot to make sure it's not being triggered off
>>>>> the mx25l25635e
>>>>> compatible but the only hit is the IC support itself.
>>>>> MX25L25635 was just the original NOR IC Qualcomm used on the board so
>>>>> to me it made
>>>>> most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR
>>>>> compatible.
>>>> OK if dynamic identification works fine
>>>
>>> It should work fine, datasheet is clear that its JEDEC compatible.
>>> That being said, I dont actually have the board, just figured it was
>>> time for a cleanup as
>>> OpenWrt has been patching DK01 and DK04 for ages.
>> Hm. Do we know whether there are still users of this boards?
> 
> I honestly doubt it as they have been broken in OpenWrt for years and
> nobody complained.
> So we are currently removing support for them, but I still wanted to
> at least fixup the DTS state
> upstream.
> These boards are not obtainable anymore.
I also noticed they were detached from the other snapdragons in u-boot
for no good reason (at first glance anyway).

If we don't get any hands up from users, I think deprecation is in order.

Konrad