linux-kernel - Re: [PATCH 1/2] gpio: sim: simplify gpio_sim_device_config_live

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mdh6EGK9hbRgEKdz_tFGDk5uqWD6E+XpJqhoXLLi8ECpQ@mail.gmail.com>
Date:   Sat, 12 Aug 2023 20:32:23 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Kent Gibson <warthog618@...il.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 1/2] gpio: sim: simplify gpio_sim_device_config_live_store()

On Fri, Aug 11, 2023 at 3:14 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Simplify the logic when checking the current live value against the user
> input.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
> This is the same as what Andy suggested for gpio-consumer. Let's save a
> line.
>
>  drivers/gpio/gpio-sim.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index dc4097dc0fbc..0177b41e0d72 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -986,8 +986,7 @@ gpio_sim_device_config_live_store(struct config_item *item,
>
>         mutex_lock(&dev->lock);
>
> -       if ((!live && !gpio_sim_device_is_live_unlocked(dev)) ||
> -           (live && gpio_sim_device_is_live_unlocked(dev)))
> +       if (live == gpio_sim_device_is_live_unlocked(dev))
>                 ret = -EPERM;
>         else if (live)
>                 ret = gpio_sim_device_activate_unlocked(dev);
> --
> 2.39.2
>

Applied.

Bart