linux-kernel - Re: [GIT PULL] tpmdd changes for v6.5-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <CUQ53HZJ7A8M.1GXKBQ7Q2F52D@suppilovahvero>
Date:   Sat, 12 Aug 2023 03:28:57 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Jarkko Sakkinen" <jarkko@...nel.org>,
        "Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:     "Peter Huewe" <peterhuewe@....de>,
        "Jason Gunthorpe" <jgg@...pe.ca>,
        "David Howells" <dhowells@...hat.com>,
        <linux-integrity@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <keyrings@...r.kernel.org>,
        "Lino Sanfilippo" <l.sanfilippo@...bus.com>
Subject: Re: [GIT PULL] tpmdd changes for v6.5-rc7

On Sat Aug 12, 2023 at 3:04 AM EEST, Jarkko Sakkinen wrote:
>   Merge tag 'mm-hotfixes-stable-2023-08-11-13-44' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm (2023-08-11 14:19:20 -0700)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git tags/tpmdd-v6.5-rc7
>
> for you to fetch changes up to 6aaf663ee04a80b445f8f5abff53cb92cb583c88:
>
>   tpm_tis: Opt-in interrupts (2023-08-12 02:36:28 +0300)
>
> ----------------------------------------------------------------
> Hi,
>
> These change the probing and enabling of interrupts advertised by the
> platform firmware (i.e. ACPI, Device Tree) to tpm_tis as an opt-in,
> which can be set from the kernel command-line.

I would add that tpm_tis represents the MMIO path to a TPM chip, and is
only one of the drivers using tpm_tis_core.

Opt-in does not concern any other drivers using IRQs, namely tpm_tis_spi
and synquacer, meaning that Lino's changes are still for profit without
question. They were just scoped wrong.

MMIO is the "PC" thing where it matters least whether you poll or use
irqs.

BR, Jarkko