linux-kernel - Re: [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3airu2djxchrycegbfb6ijp6cjlxldybo6vzl7ncfwesuitm3e@uilhuqoa6okq>
Date:   Sun, 13 Aug 2023 17:26:47 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Marc Zyngier <maz@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Philippe Mathieu-Daudé <philmd@...aro.org>,
        wangjianli <wangjianli@...rlc.com>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] irqchip: mips-gic: mark gic_irq_domain_free() static

On Thu, Aug 10, 2023 at 02:33:55PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This function is only used locally and should be static to avoid a warning:
> 
> drivers/irqchip/irq-mips-gic.c:560:6: error: no previous prototype for 'gic_irq_domain_free' [-Werror=missing-prototypes]
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/irqchip/irq-mips-gic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c
> index 6d5ecc10a8703..76253e864f230 100644
> --- a/drivers/irqchip/irq-mips-gic.c
> +++ b/drivers/irqchip/irq-mips-gic.c
> @@ -557,7 +557,7 @@ static int gic_irq_domain_alloc(struct irq_domain *d, unsigned int virq,
>  	return gic_irq_domain_map(d, virq, hwirq);
>  }
>  

> -void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
> +static void gic_irq_domain_free(struct irq_domain *d, unsigned int virq,
>  			 unsigned int nr_irqs)

Right. Thanks! Note the descendant line should be aligned to the
function open parenthesis to preserve the coding style well
utilized in the driver. With that fixed feel free to add:

Reviewed-by: Serge Semin <fancer.lancer@...il.com>

-Serge(y)

>  {
>  }
> -- 
> 2.39.2
>