[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230812210450.53464a78@rorschach.local.home>
Date: Sat, 12 Aug 2023 21:04:50 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Zheao Li <me@...jusaka.me>
Cc: edumazet@...gle.com, bpf@...r.kernel.org, davem@...emloft.net,
dsahern@...nel.org, kuba@...nel.org, linux-kernel@...r.kernel.org,
linux-trace-kernel@...r.kernel.org, mhiramat@...nel.org,
ncardwell@...gle.com, netdev@...r.kernel.org, pabeni@...hat.com,
Joe Perches <joe@...ches.com>
Subject: Re: [PATCH v3] tracepoint: add new `tcp:tcp_ca_event` trace event
On Sat, 12 Aug 2023 21:01:40 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:
> On Sat, 12 Aug 2023 20:59:05 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
>
> > On Sat, 12 Aug 2023 20:12:50 +0000
> > Zheao Li <me@...jusaka.me> wrote:
> >
> > > +TRACE_EVENT(tcp_ca_event,
> > > +
> > > + TP_PROTO(struct sock *sk, const u8 ca_event),
> > > +
> > > + TP_ARGS(sk, ca_event),
> > > +
> > > + TP_STRUCT__entry(
> > > + __field(const void *, skaddr)
> > > + __field(__u16, sport)
> > > + __field(__u16, dport)
> > > + __field(__u16, family)
> > > + __array(__u8, saddr, 4)
> > > + __array(__u8, daddr, 4)
> > > + __array(__u8, saddr_v6, 16)
> > > + __array(__u8, daddr_v6, 16)
> > > + __field(__u8, ca_event)
> >
> > Please DO NOT LISTEN TO CHECKPATCH!
I forgot to say "for TRACE_EVENT() macros". This is not about what
checkpatch says about other code.
-- Steve
> >
> > The above looks horrendous! Put it back to:
> >
> > > + __field( const void *, skaddr )
> > > + __field( __u16, sport )
> > > + __field( __u16, dport )
> > > + __field( __u16, family )
> > > + __array( __u8, saddr, 4 )
> > > + __array( __u8, daddr, 4 )
> > > + __array( __u8, saddr_v6, 16 )
> > > + __array( __u8, daddr_v6, 16 )
> > > + __field( __u8, ca_event )
> >
> > See how much better it looks I can see fields this way.
> >
> > The "checkpatch" way is a condensed mess.
> >
>
Powered by blists - more mailing lists