lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dc56700c-8617-44de-8285-720e1514ebc9@lunn.ch>
Date:   Sun, 13 Aug 2023 17:09:14 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Alfred Lee <l00g33k@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        sgarzare@...hat.com, AVKrasnov@...rdevices.ru
Subject: Re: [PATCH v2 net] net: dsa: mv88e6xxx: Wait for EEPROM done before
 HW reset

On Sun, Aug 13, 2023 at 01:58:04PM +0300, Vladimir Oltean wrote:
> Hi Alfred,
> 
> On Fri, Aug 11, 2023 at 04:28:32PM -0700, Alfred Lee wrote:
> > If the switch is reset during active EEPROM transactions, as in
> > just after an SoC reset after power up, the I2C bus transaction
> > may be cut short leaving the EEPROM internal I2C state machine
> > in the wrong state.  When the switch is reset again, the bad
> > state machine state may result in data being read from the wrong
> > memory location causing the switch to enter unexpect mode
> > rendering it inoperational.
> > 
> > Fixes: 8abbffd27ced ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")
> > Signed-off-by: Alfred Lee <l00g33k@...il.com>
> > ---
> 
> I don't think you understand the meaning of the Fixes: tag.

The subject looks correct, but the hash is wrong. The correct hash is
a3dcb3e7e70c72a68a79b30fc3a3adad5612731c.

Fixes: a3dcb3e7e70c ("net: dsa: mv88e6xxx: Wait for EEPROM done after HW reset")

       Andrew

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ