linux-kernel - Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1bda7c1e-6a4e-491b-878b-f232972f4c3d@lunn.ch>
Date:   Sun, 13 Aug 2023 20:51:53 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Daniel Golle <daniel@...rotopia.org>
Cc:     Qingfang Deng <dqfext@...il.com>,
        SkyLake Huang <SkyLake.Huang@...iatek.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs

On Sun, Aug 13, 2023 at 06:17:11PM +0100, Daniel Golle wrote:
> Hi Andrew,
> 
> thank you for reviewing my patch!
> 
> On Sun, Aug 13, 2023 at 07:03:21PM +0200, Andrew Lunn wrote:
> > Hi Daniel
> > 
> > > This requires syscon phandle 'mediatek,pio' present in parenting MDIO bus
> > > which should point to the syscon holding the boottrap register.
> > 
> > If i'm reading the code correct, if this property is missing, the PHY
> > will fail to probe? Since this was never a mandatory property, it
> > looks like this will break old DT blobs?
> 
> As the for-upstream-Linux dtsi for the MediaTek MT7988 SoC is still in
> the making there aren't any existing DT blobs we'd want to be compatible
> with at this point.

Ah. O.K. If there is need for a respin, please add that to the commit
message.

	Andrew