[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230814152746.x5l737r5ed6mmkdm@moria.home.lan>
Date: Mon, 14 Aug 2023 11:27:46 -0400
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Christian Brauner <brauner@...nel.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-bcachefs@...r.kernel.org, djwong@...nel.org,
dchinner@...hat.com, sandeen@...hat.com, willy@...radead.org,
josef@...icpanda.com, tytso@....edu, bfoster@...hat.com,
jack@...e.cz, andreas.gruenbacher@...il.com, peterz@...radead.org,
akpm@...ux-foundation.org, dhowells@...hat.com, snitzer@...nel.org,
axboe@...nel.dk
Subject: Re: [GIT PULL] bcachefs
On Mon, Aug 14, 2023 at 09:21:22AM +0200, Christian Brauner wrote:
> On Fri, Aug 11, 2023 at 09:21:41AM -0400, Kent Overstreet wrote:
> > On Fri, Aug 11, 2023 at 12:54:42PM +0200, Christian Brauner wrote:
> > > > I don't want to do that to Christian either, I think highly of the work
> > > > he's been doing and I don't want to be adding to his frustration. So I
> > > > apologize for loosing my cool earlier; a lot of that was frustration
> > > > from other threads spilling over.
> > > >
> > > > But: if he's going to be raising objections, I need to know what his
> > > > concerns are if we're going to get anywhere. Raising objections without
> > > > saying what the concerns are shuts down discussion; I don't think it's
> > > > unreasonable to ask people not to do that, and to try and stay focused
> > > > on the code.
> > >
> > > The technical aspects were made clear off-list and I believe multiple
> > > times on-list by now. Any VFS and block related patches are to be
> > > reviewed and accepted before bcachefs gets merged.
> >
> > Here's the one VFS patch in the series - could we at least get an ack
> > for this? It's a new helper, just breaks the existing d_tmpfile() up
> > into two functions - I hope we can at least agree that this patch
> > shouldn't be controversial?
> >
> > -->--
> > Subject: [PATCH] fs: factor out d_mark_tmpfile()
> >
> > New helper for bcachefs - bcachefs doesn't want the
> > inode_dec_link_count() call that d_tmpfile does, it handles i_nlink on
> > its own atomically with other btree updates
> >
> > Signed-off-by: Kent Overstreet <kent.overstreet@...ux.dev>
> > Cc: Alexander Viro <viro@...iv.linux.org.uk>
> > Cc: Christian Brauner <brauner@...nel.org>
> > Cc: linux-fsdevel@...r.kernel.org
>
> Yep, that looks good,
> Reviewed-by: Christian Brauner <brauner@...nel.org>
Thanks, much appreciated
Powered by blists - more mailing lists