linux-kernel - Re: [PATCH v4] i2c: gpio: Fix an error check in i2c_gpio_fault_injector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNpPbhqNqD90VuN1@shikoro>
Date:   Mon, 14 Aug 2023 17:59:42 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Minjie Du <duminjie@...o.com>
Cc:     Andi Shyti <andi.shyti@...nel.org>,
        "open list:I2C SUBSYSTEM HOST DRIVERS" <linux-i2c@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        opensource.kernel@...o.com, stable@...r.kernel.org
Subject: Re: [PATCH v4] i2c: gpio: Fix an error check in
 i2c_gpio_fault_injector_init()


> -		if (!i2c_gpio_debug_dir)
> +		if (IS_ERR(i2c_gpio_debug_dir))
>  			return;

AFAIK, the trend is to remove error checking from debugfs calls. It is
debug only anyhow. No need to bail out. But please double check.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)