linux-kernel - Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Aug 2023 21:43:37 +0530
From:   Sibi Sankar <quic_sibis@...cinc.com>
To:     Sudeep Holla <sudeep.holla@....com>
CC:     <cristian.marussi@....com>, <lukasz.luba@....com>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <quic_rjendra@...cinc.com>,
        <srinivas.kandagatla@...aro.org>,
        Chandra Sekhar Lingutla <quic_lingutla@...cinc.com>
Subject: Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support

Hey Sudeep,

On 8/14/23 14:55, Sudeep Holla wrote:
> On Sat, Aug 12, 2023 at 02:18:18AM +0530, Sibi Sankar wrote:
>> The perf power scale value would currently be reported as bogowatts if the
>> platform firmware supports microwatt power scale and meets the perf major
>> version requirements. Fix this by populating version information in the
>> driver private data before the call to protocol attributes is made.
>>
>> CC: Chandra Sekhar Lingutla <quic_lingutla@...cinc.com>
>> Fixes: 3630cd8130ce ("firmware: arm_scmi: Add SCMI v3.1 perf power-cost in microwatts")
>> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
>> ---
>>   drivers/firmware/arm_scmi/perf.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c
>> index c0cd556fbaae..30dedd6ebfde 100644
>> --- a/drivers/firmware/arm_scmi/perf.c
>> +++ b/drivers/firmware/arm_scmi/perf.c
>> @@ -1080,6 +1080,8 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph)
> 
> Please rebase any patch when posting upstream on upstream kernel tree.
> This definitely looks like some downstream tree. I will adjust and apply
> this time. This file never crossed 1000 line and this patch indicates
> otherwise, so I am sure Qcom has some downstream changes in this file now.

Thanks for taking time to review the patch but zero points for the ^^
deduction lol. The correct phrasing would be v6.5 rc6 hasn't crossed 1k
lines but the patch was based on next-20230809 which has the perf level
indexing mode support in addition :)

- Sibi

>